netdev - Re: [PATCH bpf-next v4 09/15] ice, xsk: migrate to new MEM_TYPE_XSK_BUFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 May 2020 19:20:15 +0200
From:   Björn Töpel <bjorn.topel@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        David Miller <davem@...emloft.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        Björn Töpel <bjorn.topel@...el.com>,
        Maxim Mikityanskiy <maximmi@...lanox.com>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        intel-wired-lan <intel-wired-lan@...ts.osuosl.org>
Subject: Re: [PATCH bpf-next v4 09/15] ice, xsk: migrate to new MEM_TYPE_XSK_BUFF_POOL

On Wed, 20 May 2020 at 19:03, Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 20 May 2020 11:47:36 +0200 Björn Töpel wrote:
> > From: Björn Töpel <bjorn.topel@...el.com>
> >
> > Remove MEM_TYPE_ZERO_COPY in favor of the new MEM_TYPE_XSK_BUFF_POOL
> > APIs.
> >
> > Cc: intel-wired-lan@...ts.osuosl.org
> > Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> > Signed-off-by: Björn Töpel <bjorn.topel@...el.com>
>
> patch 8 also has a warning I can't figure out.
>
> But here (patch 9) it's quite clear:
>
> drivers/net/ethernet/intel/ice/ice_xsk.c:414: warning: Excess function parameter 'alloc' description in 'ice_alloc_rx_bufs_zc'
> drivers/net/ethernet/intel/ice/ice_xsk.c:480: warning: Excess function parameter 'xdp' description in 'ice_construct_skb_zc'

Thanks! I'll clean that up.

Björn