netdev - Re: [net-next 03/15] igc: Add support for source address filters in core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200521092323.70b8c9b6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 21 May 2020 09:23:23 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     davem@...emloft.net, Andre Guedes <andre.guedes@...el.com>,
        netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
        Aaron Brown <aaron.f.brown@...el.com>
Subject: Re: [net-next 03/15] igc: Add support for source address filters in
 core

On Thu, 21 May 2020 00:27:46 -0700 Jeff Kirsher wrote:
>  /**
>   * igc_del_mac_filter() - Delete MAC address filter
>   * @adapter: Pointer to adapter where the filter should be deleted from
> + * #type: MAC address filter type (source or destination)

@ here^ otherwise:

drivers/net/ethernet/intel/igc/igc_main.c:2282: warning: Function parameter or member 'type' not described in 'igc_del_mac_filter'

>   * @addr: MAC address
>   *
>   * Return: 0 in case of success, negative errno code otherwise.
>   */
> -int igc_del_mac_filter(struct igc_adapter *adapter, const u8 *addr)
> +int igc_del_mac_filter(struct igc_adapter *adapter,
> +		       enum igc_mac_filter_type type, const u8 *addr)