netdev - RE: [net-next 03/15] igc: Add support for source address filters in core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61CC2BC414934749BD9F5BF3D5D94044986CC07C@ORSMSX112.amr.corp.intel.com>
Date:   Thu, 21 May 2020 22:46:21 +0000
From:   "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "Guedes, Andre" <andre.guedes@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "Brown, Aaron F" <aaron.f.brown@...el.com>
Subject: RE: [net-next 03/15] igc: Add support for source address filters in
 core

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Thursday, May 21, 2020 09:23
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>
> Cc: davem@...emloft.net; Guedes, Andre <andre.guedes@...el.com>;
> netdev@...r.kernel.org; nhorman@...hat.com; sassmann@...hat.com;
> Brown, Aaron F <aaron.f.brown@...el.com>
> Subject: Re: [net-next 03/15] igc: Add support for source address filters in core
> 
> On Thu, 21 May 2020 00:27:46 -0700 Jeff Kirsher wrote:
> >  /**
> >   * igc_del_mac_filter() - Delete MAC address filter
> >   * @adapter: Pointer to adapter where the filter should be deleted from
> > + * #type: MAC address filter type (source or destination)
> 
> @ here^ otherwise:
> 
> drivers/net/ethernet/intel/igc/igc_main.c:2282: warning: Function parameter or
> member 'type' not described in 'igc_del_mac_filter'
> 
[Kirsher, Jeffrey T] 

I will get that cleaned up.  

> >   * @addr: MAC address
> >   *
> >   * Return: 0 in case of success, negative errno code otherwise.
> >   */
> > -int igc_del_mac_filter(struct igc_adapter *adapter, const u8 *addr)
> > +int igc_del_mac_filter(struct igc_adapter *adapter,
> > +		       enum igc_mac_filter_type type, const u8 *addr)