lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 22 May 2020 15:52:20 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ecree@...arflare.com
Cc:     netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
        jiri@...nulli.us, kuba@...nel.org, pablo@...filter.org
Subject: Re: [PATCH v4 net-next] net: flow_offload: simplify hw stats check
 handling

From: Edward Cree <ecree@...arflare.com>
Date: Wed, 20 May 2020 19:18:10 +0100

> Make FLOW_ACTION_HW_STATS_DONT_CARE be all bits, rather than none, so that
>  drivers and __flow_action_hw_stats_check can use simple bitwise checks.
> 
> Pre-fill all actions with DONT_CARE in flow_rule_alloc(), rather than
>  relying on implicit semantics of zero from kzalloc, so that callers which
>  don't configure action stats themselves (i.e. netfilter) get the correct
>  behaviour by default.
> 
> Only the kernel's internal API semantics change; the TC uAPI is unaffected.
> 
> v4: move DONT_CARE setting to flow_rule_alloc() for robustness and simplicity.
> 
> v3: set DONT_CARE in nft and ct offload.
> 
> v2: rebased on net-next, removed RFC tags.
> 
> Signed-off-by: Edward Cree <ecree@...arflare.com>

Applied, thanks Edward.

Powered by blists - more mailing lists