netdev - Re: [PATCH net 0/3] rxrpc: Fix retransmission timeout and ACK discard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200522.155418.406408375053374516.davem@davemloft.net>
Date:   Fri, 22 May 2020 15:54:18 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dhowells@...hat.com
Cc:     netdev@...r.kernel.org, linux-afs@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 0/3] rxrpc: Fix retransmission timeout and ACK
 discard

From: David Howells <dhowells@...hat.com>
Date: Thu, 21 May 2020 00:21:42 +0100

> 
> Here are a couple of fixes and an extra tracepoint for AF_RXRPC:
> 
>  (1) Calculate the RTO pretty much as TCP does, rather than making
>      something up, including an initial 4s timeout (which causes return
>      probes from the fileserver to fail if a packet goes missing), and add
>      backoff.
> 
>  (2) Fix the discarding of out-of-order received ACKs.  We mustn't let the
>      hard-ACK point regress, nor do we want to do unnecessary
>      retransmission because the soft-ACK list regresses.  This is not
>      trivial, however, due to some loose wording in various old protocol
>      specs, the ACK field that should be used for this sometimes has the
>      wrong information in it.
> 
>  (3) Add a tracepoint to log a discarded ACK.
> 
> The patches are tagged here:
> 
> 	git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
> 	rxrpc-fixes-20200520

Pulled, thanks David.