netdev - Re: [PATCH] qlcnic: Complete exception handling in qlcnic_83xx_interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <bcc1585d-b32a-8f62-f061-46bfbb212961@web.de>
Date:   Mon, 25 May 2020 15:34:47 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Qiushi Wu <wu000273@....edu>
Cc:     GR-Linux-NIC-Dev@...vell.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Kangjie Lu <kjlu@....edu>,
        Manish Chopra <manishc@...vell.com>, shshaikh@...vell.com
Subject: Re: [PATCH] qlcnic: Complete exception handling in
 qlcnic_83xx_interrupt_test()

> …, function qlcnic_83xx_diag_alloc_res() is not handled by
> function qlcnic_83xx_diag_free_res() after a call of …

I have got understanding difficulties for this wording.


> Fix this issue by adding a jump target "fail_mbx_args",
> and jump to this new target when qlcnic_alloc_mbx_args() failed.

Would a wording variant like the following be more succinct?

  Thus add the jump target “fail_mbx_args” to complete the exception handling.


Regards,
Markus