lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 26 May 2020 17:07:44 +0200
From:   Krzysztof WilczyƄski <>
To:     Greg Kroah-Hartman <>
Cc:     Dan Carpenter <>,
        "Rafael J. Wysocki" <>,
        Len Brown <>, Kevin Hilman <>,
        Ulf Hansson <>,
        Pavel Machek <>, Johan Hovold <>,
        Alex Elder <>,
        Bjorn Helgaas <>,
        "James E.J. Bottomley" <>,
        "Martin K. Petersen" <>,
        Felipe Balbi <>,
        Julian Wiedmann <>,
        Karsten Graul <>,
        Ursula Braun <>,
        Jakub Kicinski <>,
        Bjorn Andersson <>,
        John Stultz <>,
        "David S. Miller" <>,,,,,,,,
Subject: Re: [PATCH 8/8] net/iucv: Use the new device_to_pm() helper to
 access struct dev_pm_ops

Hello Greg,

> It's "interesting" how using your new helper doesn't actually make the
> code smaller.  Perhaps it isn't a good helper function?

The idea for the helper was inspired by the comment Dan made to Bjorn
about Bjorn's change, as per:

It looked like a good idea to try to reduce the following:

  dev->driver && dev->driver->pm && dev->driver->pm->prepare

Into something more succinct.  Albeit, given the feedback from yourself
and Rafael, I gather that this helper is not really a good addition.

Thank you everyone and sorry for the commotion!


Powered by blists - more mailing lists