netdev - Re: [PATCH net v2] cxgb4/chcr: Enable ktls settings at run time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200526154241.24447b41@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 26 May 2020 15:42:41 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Rohit Maheshwari <rohitm@...lsio.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, secdev@...lsio.com
Subject: Re: [PATCH net v2] cxgb4/chcr: Enable ktls settings at run time

On Tue, 26 May 2020 19:36:34 +0530 Rohit Maheshwari wrote:
> Current design enables ktls setting from start, which is not
> efficient. Now the feature will be enabled when user demands
> TLS offload on any interface.
> 
> v1->v2:
> - taking ULD module refcount till any single connection exists.
> - taking rtnl_lock() before clearing tls_devops.

Callers of tls_devops don't hold the rtnl_lock.

> Signed-off-by: Rohit Maheshwari <rohitm@...lsio.com>