netdev - Re: [PATCH net v2] cxgb4/chcr: Enable ktls settings at run time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00b63ada-06d0-5298-e676-1c02e8676d61@chelsio.com>
Date:   Wed, 27 May 2020 10:02:42 +0530
From:   rohit maheshwari <rohitm@...lsio.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, secdev@...lsio.com
Subject: Re: [PATCH net v2] cxgb4/chcr: Enable ktls settings at run time


On 27/05/20 4:12 AM, Jakub Kicinski wrote:
> On Tue, 26 May 2020 19:36:34 +0530 Rohit Maheshwari wrote:
>> Current design enables ktls setting from start, which is not
>> efficient. Now the feature will be enabled when user demands
>> TLS offload on any interface.
>>
>> v1->v2:
>> - taking ULD module refcount till any single connection exists.
>> - taking rtnl_lock() before clearing tls_devops.
> Callers of tls_devops don't hold the rtnl_lock.
I think I should correct the statement here, " taking rtnl_lock()
before clearing tls_devops and device flags". There won't be any
synchronization issue while clearing tls_devops now, because I
am incrementing module refcount of CRYPTO ULD, so this will
never be called if there is any connection (new connection
request) exists.
>> Signed-off-by: Rohit Maheshwari <rohitm@...lsio.com>