netdev - Re: [PATCH net-next v2 0/2] flow_dissector, cls_flower: Add support for multiple MPLS Label Stack Entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 May 2020 09:54:47 +0200
From:   Guillaume Nault <gnault@...hat.com>
To:     David Miller <davem@...emloft.net>
Cc:     kuba@...nel.org, netdev@...r.kernel.org, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...lanox.com,
        benjamin.lahaise@...ronome.com, tom@...bertland.com,
        pieter.jansenvanvuuren@...ronome.com, pablo@...filter.org,
        liels@...lanox.com, ronye@...lanox.com
Subject: Re: [PATCH net-next v2 0/2] flow_dissector, cls_flower: Add support
 for multiple MPLS Label Stack Entries

On Mon, May 25, 2020 at 05:49:51PM -0700, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Mon, 25 May 2020 17:38:18 -0700 (PDT)
> 
> > Series applied, thanks.
> 
> Reverted, this doesn't even build with the one of the most popular drivers
> in the tree, mlx5.
> 
Well, this comes from the latest mlx5 pull request, which was posted
_after_ this patch set.

> drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_mplsoudp.c: In function ‘parse_tunnel’:
> drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_mplsoudp.c:105:52: error: ‘struct flow_dissector_key_mpls’ has no member named ‘mpls_label’
>   105 |    outer_first_mpls_over_udp.mpls_label, match.mask->mpls_label);
>       |                                                    ^~
> ./include/linux/mlx5/device.h:74:11: note: in definition of macro ‘MLX5_SET’
>    74 |  u32 _v = v; \
>       |           ^
> drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_mplsoudp.c:107:51: error: ‘struct flow_dissector_key_mpls’ has no member named ‘mpls_label’
>   107 |    outer_first_mpls_over_udp.mpls_label, match.key->mpls_label);
>       |                                                   ^~
> ./include/linux/mlx5/device.h:74:11: note: in definition of macro ‘MLX5_SET’
>    74 |  u32 _v = v; \
>       |           ^

Anyway, I'll respin.