netdev - Re: [PATCH RFC v2 3/9] net: phy: clean up get_phy_c45

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e517b38f-fe57-ab3d-3d9b-51cc3d119883@gmail.com>
Date:   Wed, 27 May 2020 09:32:33 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Russell King <rmk+kernel@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>
Cc:     Jeremy Linton <jeremy.linton@....com>, netdev@...r.kernel.org
Subject: Re: [PATCH RFC v2 3/9] net: phy: clean up get_phy_c45_ids() failure
 handling



On 5/27/2020 3:33 AM, Russell King wrote:
> When we decide that a PHY is not present, we do not need to go through
> the hoops of setting *phy_id to 0xffffffff, and then return zero to
> make get_phy_device() fail - we can return -ENODEV which will have the
> same effect.
> 
> Doing so means we no longer have to pass a pointer to phy_id in, and
> we can then clean up the clause 22 path in a similar way.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian