netdev - Re: [PATCH RFC v2 4/9] net: phy: clean up get_phy_c22

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23b33202-a512-e818-d611-a606fc2ce859@gmail.com>
Date:   Wed, 27 May 2020 09:33:04 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Russell King <rmk+kernel@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>
Cc:     Jeremy Linton <jeremy.linton@....com>, netdev@...r.kernel.org
Subject: Re: [PATCH RFC v2 4/9] net: phy: clean up get_phy_c22_id() invalid ID
 handling



On 5/27/2020 3:34 AM, Russell King wrote:
> Move the ID check from get_phy_device() into get_phy_c22_id(), which
> simplifies get_phy_device(). The ID reading functions are now
> responsible for indicating whether they found a PHY or not via their
> return code - they must return -ENODEV when a PHY is not present.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian