netdev - Re: [PATCH net] net/sched: fix infinite loop in sch_fq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200527.111211.1980078971767456943.davem@davemloft.net>
Date:   Wed, 27 May 2020 11:12:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ivecera@...hat.com
Cc:     dcaratti@...hat.com, netdev@...r.kernel.org, tahiliani@...k.edu.in,
        jhs@...atatu.com
Subject: Re: [PATCH net] net/sched: fix infinite loop in sch_fq_pie

From: Ivan Vecera <ivecera@...hat.com>
Date: Wed, 27 May 2020 09:24:51 +0200

> On Wed, 27 May 2020 02:04:26 +0200
> Davide Caratti <dcaratti@...hat.com> wrote:
> 
>> this command hangs forever:
>> 
>>  # tc qdisc add dev eth0 root fq_pie flows 65536
>> 
>>  watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [tc:1028]
 ...
>> 
>> we can't accept 65536 as a valid number for 'nflows', because the loop on
>> 'idx' in fq_pie_init() will never end. The extack message is correct, but
>> it doesn't say that 0 is not a valid number for 'flows': while at it, fix
>> this also. Add a tdc selftest to check correct validation of 'flows'.
>> 
>> CC: Ivan Vecera <ivecera@...hat.com>
>> Fixes: ec97ecf1ebe4 ("net: sched: add Flow Queue PIE packet scheduler")
>> Signed-off-by: Davide Caratti <dcaratti@...hat.com>
 ...
> Good catch, Davide.
> 
> Reviewed-by: Ivan Vecera <ivecera@...hat.com>

Applied and queued up for v5.6 -stable, thanks.