netdev - Re: [PATCH net] nfp: flower: fix used time of merge flow statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200527.111938.1919025199084337813.davem@davemloft.net>
Date:   Wed, 27 May 2020 11:19:38 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     simon.horman@...ronome.com
Cc:     jakub.kicinski@...ronome.com, netdev@...r.kernel.org,
        oss-drivers@...ronome.com, heinrich.kuhn@...ronome.com
Subject: Re: [PATCH net] nfp: flower: fix used time of merge flow statistics

From: Simon Horman <simon.horman@...ronome.com>
Date: Wed, 27 May 2020 09:44:20 +0200

> From: Heinrich Kuhn <heinrich.kuhn@...ronome.com>
> 
> Prior to this change the correct value for the used counter is calculated
> but not stored nor, therefore, propagated to user-space. In use-cases such
> as OVS use-case at least this results in active flows being removed from
> the hardware datapath. Which results in both unnecessary flow tear-down
> and setup, and packet processing on the host.
> 
> This patch addresses the problem by saving the calculated used value
> which allows the value to propagate to user-space.
> 
> Found by inspection.
> 
> Fixes: aa6ce2ea0c93 ("nfp: flower: support stats update for merge flows")
> Signed-off-by: Heinrich Kuhn <heinrich.kuhn@...ronome.com>
> Signed-off-by: Simon Horman <simon.horman@...ronome.com>

Applied and queued up for -stable, thanks.