netdev - Re: bpf-next/net-next: panic using bpf_xdp_adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7d481d62d13607f57d5ecbdaf92f1c45b189bb6.camel@mellanox.com>
Date:   Wed, 27 May 2020 01:56:15 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "dsahern@...il.com" <dsahern@...il.com>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "brouer@...hat.com" <brouer@...hat.com>
Subject: Re: bpf-next/net-next: panic using bpf_xdp_adjust_head

On Tue, 2020-05-26 at 18:31 -0600, David Ahern wrote:
> On 5/26/20 3:23 PM, Saeed Mahameed wrote:
> > Anyway I can't figure out the reason for this without extra digging
> > since in mlx5 we do xdp_set_data_meta_invalid(); before passing the
> > xdp
> > buff to the bpf program, so it is not clear why would you hit the
> > memove in bpf_xdp_adjust_head().
> 
> I commented out the metalen check in bpf_xdp_adjust_head to move on.
> 
> There are number of changes in the mlx5 driver related to xdp_buff
> setup

These changes are from net-next, the offending merge commit is from
net..
so either it is the combination of both or some single patch issue from
net.

> and running the programs, so it is the likely candidate. Let me know
> if
> you have something to test.
> 

Sure, let's aim toward this Thursday or Friday.
I will let you know.


Thanks,
Saeed.