netdev - Re: bpf-next/net-next: panic using bpf_xdp_adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea7b8966-ba4b-3cb9-7d9c-48f2c169fac4@gmail.com>
Date:   Tue, 26 May 2020 20:33:53 -0600
From:   David Ahern <dsahern@...il.com>
To:     Saeed Mahameed <saeedm@...lanox.com>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "brouer@...hat.com" <brouer@...hat.com>
Subject: Re: bpf-next/net-next: panic using bpf_xdp_adjust_head

On 5/26/20 7:56 PM, Saeed Mahameed wrote:
> On Tue, 2020-05-26 at 18:31 -0600, David Ahern wrote:
>> On 5/26/20 3:23 PM, Saeed Mahameed wrote:
>>> Anyway I can't figure out the reason for this without extra digging
>>> since in mlx5 we do xdp_set_data_meta_invalid(); before passing the
>>> xdp
>>> buff to the bpf program, so it is not clear why would you hit the
>>> memove in bpf_xdp_adjust_head().
>>
>> I commented out the metalen check in bpf_xdp_adjust_head to move on.
>>
>> There are number of changes in the mlx5 driver related to xdp_buff
>> setup
> 
> These changes are from net-next, the offending merge commit is from
> net..
> so either it is the combination of both or some single patch issue from
> net.

Good point. Just loaded top of 'net' and it works fine.

f2fb6b6275eb (HEAD -> net-master, net/master) net: stmmac: enable
timestamp snapshot for required PTP packets in dwmac v5.10a