netdev - Re: [PATCH net] net: check untrusted gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 May 2020 20:25:22 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     netdev@...r.kernel.org, willemb@...gle.com,
        syzkaller@...glegroups.com
Subject: Re: [PATCH net] net: check untrusted gso_size at kernel entry

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Mon, 25 May 2020 15:07:40 -0400

> From: Willem de Bruijn <willemb@...gle.com>
> 
> Syzkaller again found a path to a kernel crash through bad gso input:
> a packet with gso size exceeding len.
> 
> These packets are dropped in tcp_gso_segment and udp[46]_ufo_fragment.
> But they may affect gso size calculations earlier in the path.
> 
> Now that we have thlen as of commit 9274124f023b ("net: stricter
> validation of untrusted gso packets"), check gso_size at entry too.
> 
> Fixes: bfd5f4a3d605 ("packet: Add GSO/csum offload support.")
> Reported-by: syzbot <syzkaller@...glegroups.com>
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Applied and queued up for -stable, thanks Willem.