netdev - Re: [PATCH bpf-next] libbpf: fix perf_buffer_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200528135251.GA24961@pc-9.home>
Date:   Thu, 28 May 2020 15:52:51 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Eelco Chaudron <echaudro@...hat.com>
Cc:     Andrii Nakryiko <andrii.nakryiko@...il.com>,
        bpf <bpf@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>, Martin Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andriin@...com>,
        Toke Høiland-Jørgensen <toke@...hat.com>
Subject: Re: [PATCH bpf-next] libbpf: fix perf_buffer__free() API for sparse
 allocs

On Thu, May 28, 2020 at 09:24:58AM +0200, Eelco Chaudron wrote:
> On 27 May 2020, at 19:58, Andrii Nakryiko wrote:
> > On Wed, May 27, 2020 at 1:42 AM Eelco Chaudron <echaudro@...hat.com>
> > wrote:
> > > 
> > > In case the cpu_bufs are sparsely allocated they are not
> > > all free'ed. These changes will fix this.
> > > 
> > > Signed-off-by: Eelco Chaudron <echaudro@...hat.com>
> > > ---
> > 
> > Thanks a lot!
> > 
> > You forgot:
> > 
> > Fixes: fb84b8224655 ("libbpf: add perf buffer API")
> 
> Thanks, I forgot that :(  Daniel do you want me to send a v2, or will you
> add it when you apply it?

No worries, added it. Applied to bpf-next, thanks!