netdev - Re: [PATCH net] net: dsa: sja1105: fix port mirroring for P/Q/R/S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200529.164506.2200622965835884094.davem@davemloft.net>
Date:   Fri, 29 May 2020 16:45:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, vivien.didelot@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: sja1105: fix port mirroring for P/Q/R/S

From: Vladimir Oltean <olteanv@...il.com>
Date: Wed, 27 May 2020 19:40:06 +0300

> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> The dynamic configuration interface for the General Params and the L2
> Lookup Params tables was copy-pasted between E/T devices and P/Q/R/S
> devices. Nonetheless, these interfaces are bitwise different (and not to
> mention, located at different SPI addresses).
> 
> The driver is using dynamic reconfiguration of the General Parameters
> table for the port mirroring feature, which was therefore broken on
> P/Q/R/S.
> 
> Note that I don't think this patch can be backported very far to stable
> trees (since it conflicts with some other development done since the
> introduction of the driver).
> 
> Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Please fix the build errors reported by the kbuild robot.