lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 30 May 2020 13:33:33 +0300 From: Vladimir Oltean <olteanv@...il.com> To: David Miller <davem@...emloft.net> Cc: Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, Vivien Didelot <vivien.didelot@...il.com>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH net] net: dsa: sja1105: fix port mirroring for P/Q/R/S On Sat, 30 May 2020 at 02:45, David Miller <davem@...emloft.net> wrote: > > From: Vladimir Oltean <olteanv@...il.com> > Date: Wed, 27 May 2020 19:40:06 +0300 > > > From: Vladimir Oltean <vladimir.oltean@....com> > > > > The dynamic configuration interface for the General Params and the L2 > > Lookup Params tables was copy-pasted between E/T devices and P/Q/R/S > > devices. Nonetheless, these interfaces are bitwise different (and not to > > mention, located at different SPI addresses). > > > > The driver is using dynamic reconfiguration of the General Parameters > > table for the port mirroring feature, which was therefore broken on > > P/Q/R/S. > > > > Note that I don't think this patch can be backported very far to stable > > trees (since it conflicts with some other development done since the > > introduction of the driver). > > > > Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch") > > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com> > > Please fix the build errors reported by the kbuild robot. So the kbuild robot said that it couldn't apply the patch on net, so it tried on net-next and hit some further W=1 warnings. So I've fixed the warnings and targeted the patch against net-next: https://patchwork.ozlabs.org/project/netdev/cover/20200530102953.692780-1-olteanv@gmail.com/ (I don't think anybody should care enough that they should deal with the resulting conflicts from targeting against net). Thanks, -Vladimir
Powered by blists - more mailing lists