lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 30 May 2020 11:40:40 -0700
From:   Florian Fainelli <>
To:     Vladimir Oltean <>,,,
Subject: Re: [PATCH net-next 1/2] net: dsa: sja1105: suppress
 -Wmissing-prototypes in sja1105_static_config.c

On 5/30/2020 3:29 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <>
> Newer compilers complain with W=1 builds that there are non-static
> functions defined in sja1105_static_config.c that don't have a
> prototype, because their prototype is defined in sja1105.h which this
> translation unit does not include.
> I don't entirely understand what is the point of these warnings, since
> in principle there's nothing wrong with that. But let's move the
> prototypes to a header file that _is_ included by
> sja1105_static_config.c, since that will make these warnings go away.
> Signed-off-by: Vladimir Oltean <>

Reviewed-by: Florian Fainelli <>

Powered by blists - more mailing lists