netdev - Re: [PATCH v2 net-next 02/13] net: dsa: felix: set proper link speed in felix_phylink_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2cfb7e23-cfe5-4a95-b52e-78e1697ddbfa@gmail.com>
Date:   Sat, 30 May 2020 13:43:49 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, andrew@...n.ch, vivien.didelot@...il.com,
        antoine.tenart@...tlin.com, alexandre.belloni@...tlin.com,
        UNGLinuxDriver@...rochip.com, alexandru.marginean@....com,
        claudiu.manoil@....com, madalin.bucur@....nxp.com,
        radu-andrei.bulie@....com, fido_max@...ox.ru, broonie@...nel.org
Subject: Re: [PATCH v2 net-next 02/13] net: dsa: felix: set proper link speed
 in felix_phylink_mac_config



On 5/30/2020 4:51 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> state->speed holds a value of 10, 100, 1000 or 2500, but
> SYS_MAC_FC_CFG_FC_LINK_SPEE and DEV_CLOCK_CFG_LINK_SPEED expect a value
> in the range 0, 1, 2 or 3.
> 
> Even truncated to 2 bits, we are still writing incorrect values to the
> registers, but for some reason Felix still works.
> 
> On Seville (which we're introducing now), however, we need to set
> correct values for the link speed into the MAC registers. Do that now.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian