netdev - Re: [PATCH v2 net-next 03/13] net: mscc: ocelot: convert port registers to regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <237eb0b4-993d-89d5-b389-7f95c56da938@gmail.com>
Date:   Sat, 30 May 2020 13:45:45 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, andrew@...n.ch, vivien.didelot@...il.com,
        antoine.tenart@...tlin.com, alexandre.belloni@...tlin.com,
        UNGLinuxDriver@...rochip.com, alexandru.marginean@....com,
        claudiu.manoil@....com, madalin.bucur@....nxp.com,
        radu-andrei.bulie@....com, fido_max@...ox.ru, broonie@...nel.org
Subject: Re: [PATCH v2 net-next 03/13] net: mscc: ocelot: convert port
 registers to regmap



On 5/30/2020 4:51 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> At the moment, there are some minimal register differences between
> VSC7514 Ocelot and VSC9959 Felix. To be precise, the PCS1G registers are
> missing from Felix because it was integrated with an NXP PCS.
> 
> But with VSC9953 Seville (not yet introduced), the register differences
> are more pronounced.  The MAC registers are located at different offsets
> within the DEV_GMII target. So we need to refactor the driver to keep a
> regmap even for per-port registers. The callers of the ocelot_port_readl
> and ocelot_port_writel were kept unchanged, only the implementation is
> now more generic.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian