lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 29 May 2020 21:49:42 -0700
From:   Cong Wang <>
To:     Arnd Bergmann <>
Cc:     Jamal Hadi Salim <>, Jiri Pirko <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        Guillaume Nault <>,
        Vlad Buslov <>,
        Xin Long <>,
        Pablo Neira Ayuso <>,
        Linux Kernel Network Developers <>,
        LKML <>
Subject: Re: [PATCH] flow_dissector: work around stack frame size warning

On Fri, May 29, 2020 at 1:14 PM Arnd Bergmann <> wrote:
> The fl_flow_key structure is around 500 bytes, so having two of them
> on the stack in one function now exceeds the warning limit after an
> otherwise correct change:
> net/sched/cls_flower.c:298:12: error: stack frame size of 1056 bytes in function 'fl_classify' [-Werror,-Wframe-larger-than=]
> I suspect the fl_classify function could be reworked to only have one
> of them on the stack and modify it in place, but I could not work out
> how to do that.
> As a somewhat hacky workaround, move one of them into an out-of-line
> function to reduce its scope. This does not necessarily reduce the stack
> usage of the outer function, but at least the second copy is removed
> from the stack during most of it and does not add up to whatever is
> called from there.
> I now see 552 bytes of stack usage for fl_classify(), plus 528 bytes
> for fl_mask_lookup().
> Fixes: 58cff782cc55 ("flow_dissector: Parse multiple MPLS Label Stack Entries")
> Signed-off-by: Arnd Bergmann <>

I think this is probably the quickest way to amend this warning,

Acked-by: Cong Wang <>


Powered by blists - more mailing lists