[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAM_iQpVesOZ0kQ2OWHss1kG3O5tvYUYETK4A3LW9doH5ZFQjmw@mail.gmail.com>
Date: Fri, 29 May 2020 22:17:15 -0700
From: Cong Wang <xiyou.wangcong@...il.com>
To: Davide Caratti <dcaratti@...hat.com>
Cc: Linux Kernel Network Developers <netdev@...r.kernel.org>,
"David S. Miller" <davem@...emloft.net>, Po Liu <po.liu@....com>,
Jamal Hadi Salim <jhs@...atatu.com>,
Ivan Vecera <ivecera@...hat.com>
Subject: Re: [PATCH net-next v2] net/sched: fix a couple of splats in the
error path of tcf_gate_init()
On Fri, May 29, 2020 at 11:10 AM Davide Caratti <dcaratti@...hat.com> wrote:
>
> this is caused by hrtimer_cancel(), running before hrtimer_init(). Fix it
> ensuring to call hrtimer_cancel() only if clockid is valid, and the timer
> has been initialized. After fixing this splat, the same error path causes
> another problem:
Hmm, but hrtimer_init() should not be called for an existing action
either, right? If so, we need to move it under ACT_P_CREATED too,
and you do not need to touch tcf_gate_cleanup() any more.
Thanks.
Powered by blists - more mailing lists