netdev - Re: [PATCH v3 net-next 12/13] net: dsa: felix: move probing to felix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200601141425.3c36f08b@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Mon, 1 Jun 2020 14:14:25 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com,
        antoine.tenart@...tlin.com, alexandre.belloni@...tlin.com,
        UNGLinuxDriver@...rochip.com, alexandru.marginean@....com,
        claudiu.manoil@....com, madalin.bucur@....nxp.com,
        radu-andrei.bulie@....com, fido_max@...ox.ru, broonie@...nel.org
Subject: Re: [PATCH v3 net-next 12/13] net: dsa: felix: move probing to
 felix_vsc9959.c

On Sun, 31 May 2020 15:26:39 +0300 Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> Felix is not actually meant to be a DSA driver only for the switch
> inside NXP LS1028A, but an umbrella for all Vitesse / Microsemi /
> Microchip switches that are register-compatible with Ocelot and that are
> using in DSA mode (with an NPI Ethernet port).
> 
> For the dsa_switch_ops exported by the felix driver to be generic enough
> to be used by other non-PCI switches, we need to move the PCI-specific
> probing to the low-level translation module felix_vsc9959.c. This way,
> other switches can have their own probing functions, as platform devices
> or otherwise.
> 
> This patch also removes the "Felix instance table", which did not stand
> the test of time and is unnecessary at this point.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

drivers/net/dsa/ocelot/felix_vsc9959.c:1520:25: warning: symbol 'felix_info_vsc9959' was not declared. Should it be static?