netdev - Re: [PATCH v3 net-next 13/13] net: dsa: felix: introduce support for Seville VSC9953 switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200601141448.1f9f3c78@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Mon, 1 Jun 2020 14:14:48 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com,
        antoine.tenart@...tlin.com, alexandre.belloni@...tlin.com,
        UNGLinuxDriver@...rochip.com, alexandru.marginean@....com,
        claudiu.manoil@....com, madalin.bucur@....nxp.com,
        radu-andrei.bulie@....com, fido_max@...ox.ru, broonie@...nel.org
Subject: Re: [PATCH v3 net-next 13/13] net: dsa: felix: introduce support
 for Seville VSC9953 switch

On Sun, 31 May 2020 15:26:40 +0300 Vladimir Oltean wrote:
> From: Maxim Kochetkov <fido_max@...ox.ru>
> 
> This is another switch from Vitesse / Microsemi / Microchip, that has
> 10 port (8 external, 2 internal) and is integrated into the Freescale /
> NXP T1040 PowerPC SoC. It is very similar to Felix from NXP LS1028A,
> except that this is a platform device and Felix is a PCI device, and it
> doesn't support IEEE 1588 and TSN.
> 
> Like Felix, this driver configures its own PCS on the internal MDIO bus
> using a phy_device abstraction for it (yes, it will be refactored to use
> a raw mdio_device, like other phylink drivers do, but let's keep it like
> that for now). But unlike Felix, the MDIO bus and the PCS are not from
> the same vendor. The PCS is the same QorIQ/Layerscape PCS as found in
> Felix/ENETC/DPAA*, but the internal MDIO bus that is used to access it
> is actually an instantiation of drivers/net/phy/mdio-mscc-miim.c. But it
> would be difficult to reuse that driver (it doesn't even use regmap, and
> it's less than 200 lines of code), so we hand-roll here some internal
> MDIO bus accessors within seville_vsc9953.c, which serves the purpose of
> driving the PCS absolutely fine.
> 
> Also, same as Felix, the PCS doesn't support dynamic reconfiguration of
> SerDes protocol, so we need to do pre-validation of PHY mode from device
> tree and not let phylink change it.
> 
> Signed-off-by: Maxim Kochetkov <fido_max@...ox.ru>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

drivers/net/dsa/ocelot/seville_vsc9953.c:1003:19: warning: symbol 'seville_info_vsc9953' was not declared. Should it be static?