netdev - Re: [PATCH 14/15] net: hns3: use PCI_IRQ_MSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfEcm-Mmo7=i40sJ0RqpOgFRpJHxQ9ePWvvqsyRp+=9GA@mail.gmail.com>
Date:   Tue, 2 Jun 2020 18:39:12 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Piotr Stankiewicz <piotr.stankiewicz@...el.com>
Cc:     Yisen Zhuang <yisen.zhuang@...wei.com>,
        Salil Mehta <salil.mehta@...wei.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 14/15] net: hns3: use PCI_IRQ_MSI_TYPES where appropriate

On Tue, Jun 2, 2020 at 12:26 PM Piotr Stankiewicz
<piotr.stankiewicz@...el.com> wrote:
>
> Seeing as there is shorthand available to use when asking for any type
> of interrupt, or any type of message signalled interrupt, leverage it.

...

>         vectors = pci_alloc_irq_vectors(pdev, HNAE3_MIN_VECTOR_NUM,
> -                                       hdev->num_msi,
> -                                       PCI_IRQ_MSI | PCI_IRQ_MSIX);
> +                                       hdev->num_msi, PCI_IRQ_MSI_TYPES);

...

>                 vectors = pci_alloc_irq_vectors(pdev, HNAE3_MIN_VECTOR_NUM,

>                                                 hdev->num_msi,
> -                                               PCI_IRQ_MSI | PCI_IRQ_MSIX);
> +                                               PCI_IRQ_MSI_TYPES);

One line as above?

-- 
With Best Regards,
Andy Shevchenko