netdev - RE: [PATCH 14/15] net: hns3: use PCI_IRQ_MSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Jun 2020 08:49:53 +0000
From:   "Stankiewicz, Piotr" <piotr.stankiewicz@...el.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Yisen Zhuang <yisen.zhuang@...wei.com>,
        Salil Mehta <salil.mehta@...wei.com>,
        "David S . Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 14/15] net: hns3: use PCI_IRQ_MSI_TYPES where appropriate

> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@...il.com>
> Sent: Tuesday, June 2, 2020 5:39 PM
> 
> On Tue, Jun 2, 2020 at 12:26 PM Piotr Stankiewicz
> <piotr.stankiewicz@...el.com> wrote:
> >
> > Seeing as there is shorthand available to use when asking for any type
> > of interrupt, or any type of message signalled interrupt, leverage it.
> 
> ...
> 
> >         vectors = pci_alloc_irq_vectors(pdev, HNAE3_MIN_VECTOR_NUM,
> > -                                       hdev->num_msi,
> > -                                       PCI_IRQ_MSI | PCI_IRQ_MSIX);
> > +                                       hdev->num_msi, PCI_IRQ_MSI_TYPES);
> 
> ...
> 
> >                 vectors = pci_alloc_irq_vectors(pdev, HNAE3_MIN_VECTOR_NUM,
> 
> >                                                 hdev->num_msi,
> > -                                               PCI_IRQ_MSI | PCI_IRQ_MSIX);
> > +                                               PCI_IRQ_MSI_TYPES);
> 
> One line as above?
> 

It would push the line above 80 characters. 

> --
> With Best Regards,
> Andy Shevchenko

BR,
Piotr