netdev - Re: [PATCH net-next] net: ethernet: dwmac: Fix an error code in imx_dwmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200604.155235.1008812507143457607.davem@davemloft.net>
Date:   Thu, 04 Jun 2020 15:52:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     peppe.cavallaro@...com, fugang.duan@....com,
        alexandre.torgue@...com, joabreu@...opsys.com, kuba@...nel.org,
        mcoquelin.stm32@...il.com, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        linux-imx@....com, netdev@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: ethernet: dwmac: Fix an error code in
 imx_dwmac_probe()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Wed, 3 Jun 2020 20:50:25 +0300

> The code is return PTR_ERR(NULL) which is zero or success.  We should
> return -ENOMEM instead.
> 
> Fixes: 94abdad6974a5 ("net: ethernet: dwmac: add ethernet glue logic for NXP imx8 chip")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.