netdev - Re: [PATCH v2 net-next] r8169: fix failing WoL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200604.155241.2183763810929782758.davem@davemloft.net>
Date:   Thu, 04 Jun 2020 15:52:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     kuba@...nel.org, nic_swsd@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] r8169: fix failing WoL

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Wed, 3 Jun 2020 22:29:06 +0200

> Th referenced change added an extra hw reset to rtl8169_net_suspend()
> what makes WoL fail on few chip versions. Therefore skip the extra
> reset if we're going down and WoL is enabled.
> In rtl_shutdown() rtl8169_hw_reset() is called by rtl8169_net_suspend()
> already if needed, therefore avoid issues issue by removing the extra
> call. The fix was tested on a system with RTL8168g.
> 
> Meanwhile rtl8169_hw_reset() does more than a hw reset and should be
> renamed. But that's net-next material.
> 
> Fixes: 8ac8e8c64b53 ("r8169: make rtl8169_down central chip quiesce function")
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied.