netdev - Re: [PATCH] xfrm: Fix double ESP trailer insertion in IPsec crypto offload.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200605091712.GC19286@gauss3.secunet.de>
Date:   Fri, 5 Jun 2020 11:17:12 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Huy Nguyen <huyn@...lanox.com>
CC:     <davem@...emloft.net>, <saeedm@...lanox.com>,
        <borisp@...lanox.com>, <raeds@...lanox.com>,
        <netdev@...r.kernel.org>, <huyn@...dia.com>
Subject: Re: [PATCH] xfrm: Fix double ESP trailer insertion in IPsec crypto
 offload.

On Mon, Jun 01, 2020 at 04:39:37PM -0500, Huy Nguyen wrote:
> During IPsec performance testing, we see bad ICMP checksum. The error packet
> has duplicated ESP trailer due to double validate_xmit_xfrm calls. The first call
> is from ip_output, but the packet cannot be sent because
> netif_xmit_frozen_or_stopped is true and the packet gets dev_requeue_skb. The second
> call is from NET_TX softirq. However after the first call, the packet already
> has the ESP trailer.
> 
> Fix by marking the skb with XFRM_XMIT bit after the packet is handled by
> validate_xmit_xfrm to avoid duplicate ESP trailer insertion.
> 
> Fixes: f6e27114a60a ("net: Add a xfrm validate function to validate_xmit_skb")
> Signed-off-by: Huy Nguyen <huyn@...lanox.com>
> Reviewed-by: Boris Pismenny <borisp@...lanox.com>
> Reviewed-by: Raed Salem <raeds@...lanox.com>
> Reviewed-by: Saeed Mahameed <saeedm@...lanox.com>

Applied, thanks a lot!