lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 05 Jun 2020 12:18:22 +0300 From: Kalle Valo <kvalo@...eaurora.org> To: Kees Cook <keescook@...omium.org> Cc: linux-kernel@...r.kernel.org, Linus Torvalds <torvalds@...ux-foundation.org>, Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, Alexander Potapenko <glider@...gle.com>, Joe Perches <joe@...ches.com>, Andy Whitcroft <apw@...onical.com>, x86@...nel.org, drbd-dev@...ts.linbit.com, linux-block@...r.kernel.org, b43-dev@...ts.infradead.org, netdev@...r.kernel.org, linux-wireless@...r.kernel.org, linux-ide@...r.kernel.org, linux-clk@...r.kernel.org, linux-spi@...r.kernel.org, linux-mm@...ck.org, clang-built-linux@...glegroups.com Subject: Re: [PATCH 04/10] rtlwifi: rtl8192cu: Remove uninitialized_var() usage Kees Cook <keescook@...omium.org> writes: > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings (e.g. > "unused variable"). If the compiler thinks it is uninitialized, either > simply initialize the variable or make compiler changes. As a precursor > to removing[2] this[3] macro[4], just initialize this variable to NULL, > and avoid sending garbage by returning. > > [1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/ > [2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/ > [3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/ > [4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/ > > Signed-off-by: Kees Cook <keescook@...omium.org> To which tree should this go? If something else than wireless-drivers tree: Acked-by: Kalle Valo <kvalo@...eaurora.org> But let me know if you want me to take this. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists