netdev - Re: [RFC PATCH net-next 10/10] selftests: forwarding: Add tests for ethtool extended state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35598572-df37-75cf-9f58-ad387af2f245@gmail.com>
Date:   Sun, 7 Jun 2020 11:22:27 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Amit Cohen <amitc@...lanox.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, corbet@....net,
        jiri@...lanox.com, idosch@...lanox.com, shuah@...nel.org,
        mkubecek@...e.cz, gustavo@...eddedor.com,
        cforno12@...ux.vnet.ibm.com, andrew@...n.ch,
        linux@...pel-privat.de, alexandru.ardelean@...log.com,
        ayal@...lanox.com, petrm@...lanox.com, mlxsw@...lanox.com,
        liuhangbin@...il.com, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [RFC PATCH net-next 10/10] selftests: forwarding: Add tests for
 ethtool extended state



On 6/7/2020 7:59 AM, Amit Cohen wrote:
> Add tests to check ethtool report about extended state.
> The tests configure several states and verify that the correct extended
> state is reported by ethtool.
> 
> Check extended state with substate (Autoneg) and extended state without
> substate (No cable).
> 
> Signed-off-by: Amit Cohen <amitc@...lanox.com>
> Reviewed-by: Petr Machata <petrm@...lanox.com>

The delays you have chosen make sense, and if we need to change them
later on, we could always do that.

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian