netdev - Re: [RFC PATCH net-next 07/10] mlxsw: spectrum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7dcb004e-7bab-3026-7863-af16c1a4d556@gmail.com>
Date:   Sun, 7 Jun 2020 11:25:35 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Amit Cohen <amitc@...lanox.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, corbet@....net,
        jiri@...lanox.com, idosch@...lanox.com, shuah@...nel.org,
        mkubecek@...e.cz, gustavo@...eddedor.com,
        cforno12@...ux.vnet.ibm.com, andrew@...n.ch,
        linux@...pel-privat.de, alexandru.ardelean@...log.com,
        ayal@...lanox.com, petrm@...lanox.com, mlxsw@...lanox.com,
        liuhangbin@...il.com, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [RFC PATCH net-next 07/10] mlxsw: spectrum_ethtool: Add link
 extended state



On 6/7/2020 7:59 AM, Amit Cohen wrote:
> Implement .get_down_ext_state() as part of ethtool_ops.
> Query link down reason from PDDR register and convert it to ethtool
> ext_state.
> 
> In case that more information than common ext_state is provided,
> fill ext_substate also with the appropriate value.
> 
> Signed-off-by: Amit Cohen <amitc@...lanox.com>
> Reviewed-by: Petr Machata <petrm@...lanox.com>
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>

Is the firmware smart enough to report
ETHTOOL_EXT_SUBSTATE_LT_KR_FRAME_LOCK_NOT_ACQUIRED only when using a *KR
link mode for instance, or do you need to sanitize that against the
supported/advertised mode?
-- 
Florian