netdev - Re: [patch 1/1] net-zerocopy: use vm_insert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200608.190836.147361780330392366.davem@davemloft.net>
Date:   Mon, 08 Jun 2020 19:08:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     akpm@...ux-foundation.org
Cc:     arjunroy@...gle.com, edumazet@...gle.com, jgg@...pe.ca,
        netdev@...r.kernel.org, sfr@...b.auug.org.au, soheil@...gle.com,
        willy@...radead.org
Subject: Re: [patch 1/1] net-zerocopy: use vm_insert_pages() for tcp rcv
 zerocopy

From: akpm@...ux-foundation.org
Date: Sun, 07 Jun 2020 18:54:41 -0700

> From: Arjun Roy <arjunroy@...gle.com>
> Subject: net-zerocopy: use vm_insert_pages() for tcp rcv zerocopy
> 
> Use vm_insert_pages() for tcp receive zerocopy.  Spin lock cycles (as
> reported by perf) drop from a couple of percentage points to a fraction of
> a percent.  This results in a roughly 6% increase in efficiency, measured
> roughly as zerocopy receive count divided by CPU utilization.
> 
> The intention of this patchset is to reduce atomic ops for tcp zerocopy
> receives, which normally hits the same spinlock multiple times
> consecutively.
> 
> [akpm@...ux-foundation.org: suppress gcc-7.2.0 warning]
> Link: http://lkml.kernel.org/r/20200128025958.43490-3-arjunroy.kdev@gmail.com
> Signed-off-by: Arjun Roy <arjunroy@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> Cc: David Miller <davem@...emloft.net>
> Cc: Matthew Wilcox <willy@...radead.org>
> Cc: Jason Gunthorpe <jgg@...pe.ca>
> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

Applied, thank you.