netdev - Re: [PATCH net v2] mptcp: bugfix for RM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200608.191108.1901661787245617914.davem@davemloft.net>
Date:   Mon, 08 Jun 2020 19:11:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     geliangtang@...il.com
Cc:     mathew.j.martineau@...ux.intel.com, matthieu.baerts@...sares.net,
        kuba@...nel.org, pabeni@...hat.com, peter.krystad@...ux.intel.com,
        netdev@...r.kernel.org, mptcp@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] mptcp: bugfix for RM_ADDR option parsing

From: Geliang Tang <geliangtang@...il.com>
Date: Mon,  8 Jun 2020 18:47:54 +0800

> In MPTCPOPT_RM_ADDR option parsing, the pointer "ptr" pointed to the
> "Subtype" octet, the pointer "ptr+1" pointed to the "Address ID" octet:
> 
>   +-------+-------+---------------+
>   |Subtype|(resvd)|   Address ID  |
>   +-------+-------+---------------+
>   |               |
>  ptr            ptr+1
> 
> We should set mp_opt->rm_id to the value of "ptr+1", not "ptr". This patch
> will fix this bug.
> 
> Fixes: 3df523ab582c ("mptcp: Add ADD_ADDR handling")
> Signed-off-by: Geliang Tang <geliangtang@...il.com>
> ---
>  Changes in v2:
>   - Add "-net" subject and "Fixes" tag as Matt suggested.

Applied and queued up for v5.7 -stable, thanks!