netdev - Re: [PATCH v2 net] nexthop: Fix fdb labeling for groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200610.131902.2093057899383691022.davem@davemloft.net>
Date:   Wed, 10 Jun 2020 13:19:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, kuba@...nel.org, roopa@...ulusnetworks.com
Subject: Re: [PATCH v2 net] nexthop: Fix fdb labeling for groups

From: David Ahern <dsahern@...nel.org>
Date: Mon,  8 Jun 2020 20:54:43 -0600

> fdb nexthops are marked with a flag. For standalone nexthops, a flag was
> added to the nh_info struct. For groups that flag was added to struct
> nexthop when it should have been added to the group information. Fix
> by removing the flag from the nexthop struct and adding a flag to nh_group
> that mirrors nh_info and is really only a caching of the individual types.
> Add a helper, nexthop_is_fdb, for use by the vxlan code and fixup the
> internal code to use the flag from either nh_info or nh_group.
> 
> v2
> - propagate fdb_nh in remove_nh_grp_entry
> 
> Fixes: 38428d68719c ("nexthop: support for fdb ecmp nexthops")
> Cc: Roopa Prabhu <roopa@...ulusnetworks.com>
> Signed-off-by: David Ahern <dsahern@...nel.org>

Applied, thanks David.