netdev - Re: [PATCH v2 net] nexthop: Fix fdb labeling for groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJieiUiMccp8yXETq6XGdWkKYYtO1XqS+KXfOOYiZAbXCoJiGA@mail.gmail.com>
Date:   Wed, 10 Jun 2020 13:33:41 -0700
From:   Roopa Prabhu <roopa@...ulusnetworks.com>
To:     David Ahern <dsahern@...nel.org>
Cc:     netdev <netdev@...r.kernel.org>, kuba@...nel.org,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH v2 net] nexthop: Fix fdb labeling for groups

On Mon, Jun 8, 2020 at 7:54 PM David Ahern <dsahern@...nel.org> wrote:
>
> fdb nexthops are marked with a flag. For standalone nexthops, a flag was
> added to the nh_info struct. For groups that flag was added to struct
> nexthop when it should have been added to the group information. Fix
> by removing the flag from the nexthop struct and adding a flag to nh_group
> that mirrors nh_info and is really only a caching of the individual types.
> Add a helper, nexthop_is_fdb, for use by the vxlan code and fixup the
> internal code to use the flag from either nh_info or nh_group.
>
> v2
> - propagate fdb_nh in remove_nh_grp_entry
>
> Fixes: 38428d68719c ("nexthop: support for fdb ecmp nexthops")
> Cc: Roopa Prabhu <roopa@...ulusnetworks.com>
> Signed-off-by: David Ahern <dsahern@...nel.org>

nice cleanups. Thanks David.

looks like the patches were just applied, FWIW,
Acked-by: Roopa Prabhu <roopa@...ulusnetworks.com>