netdev - Re: [PATCH net] mptcp: don't leak msk in token container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 Jun 2020 16:10:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, kuba@...nel.org, mptcp@...ts.01.org
Subject: Re: [PATCH net] mptcp: don't leak msk in token container

From: Paolo Abeni <pabeni@...hat.com>
Date: Wed, 10 Jun 2020 10:49:00 +0200

> If a listening MPTCP socket has unaccepted sockets at close
> time, the related msks are freed via mptcp_sock_destruct(),
> which in turn does not invoke the proto->destroy() method
> nor the mptcp_token_destroy() function.
> 
> Due to the above, the child msk socket is not removed from
> the token container, leading to later UaF.
> 
> Address the issue explicitly removing the token even in the
> above error path.
> 
> Fixes: 79c0949e9a09 ("mptcp: Add key generation and token tree")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Also applied and queued up for v5.6 -stable, thanks.