netdev - Re: [MPTCP] [PATCH net] mptcp: don't leak msk in token container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88f6e442-44a7-c33f-33ab-f88c90c35514@tessares.net>
Date:   Wed, 10 Jun 2020 12:04:04 +0200
From:   Matthieu Baerts <matthieu.baerts@...sares.net>
To:     Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, mptcp@...ts.01.org
Subject: Re: [MPTCP] [PATCH net] mptcp: don't leak msk in token container

Hi Paolo,

On 10/06/2020 10:49, Paolo Abeni wrote:
> If a listening MPTCP socket has unaccepted sockets at close
> time, the related msks are freed via mptcp_sock_destruct(),
> which in turn does not invoke the proto->destroy() method
> nor the mptcp_token_destroy() function.
> 
> Due to the above, the child msk socket is not removed from
> the token container, leading to later UaF.
> 
> Address the issue explicitly removing the token even in the
> above error path.
> 
> Fixes: 79c0949e9a09 ("mptcp: Add key generation and token tree")
 > Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Thank you for the patch, it looks good to me!

Reviewed-by: Matthieu Baerts <matthieu.baerts@...sares.net>

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts@...sares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium