netdev - Re: [PATCH net] ionic: remove support for mgmt device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9bf6b140-f099-29ce-011e-e46c950b8150@redhat.com>
Date:   Thu, 11 Jun 2020 22:33:59 +0200
From:   Michal Schmidt <mschmidt@...hat.com>
To:     Shannon Nelson <snelson@...sando.io>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net] ionic: remove support for mgmt device

Dne 11. 06. 20 v 6:07 Shannon Nelson napsal(a):
> We no longer support the mgmt device in the ionic driver,
> so remove the device id and related code.
...> @@ -252,8 +248,6 @@ static int ionic_probe(struct pci_dev *pdev, 
const struct pci_device_id *ent)
>   	}
>   
>   	pci_set_master(pdev);
> -	if (!ionic->is_mgmt_nic)
> -		pcie_print_link_status(pdev);

Was removing the call intentional? Notice the condition is negated.

Michal