netdev - Re: [PATCH net] ionic: remove support for mgmt device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ff60c550-b7a3-5ecb-1b1d-5bddb96ddd35@pensando.io>
Date:   Thu, 11 Jun 2020 14:57:46 -0700
From:   Shannon Nelson <snelson@...sando.io>
To:     Michal Schmidt <mschmidt@...hat.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net] ionic: remove support for mgmt device

On 6/11/20 1:33 PM, Michal Schmidt wrote:
> Dne 11. 06. 20 v 6:07 Shannon Nelson napsal(a):
>> We no longer support the mgmt device in the ionic driver,
>> so remove the device id and related code.
> ...> @@ -252,8 +248,6 @@ static int ionic_probe(struct pci_dev *pdev, 
> const struct pci_device_id *ent)
>>       }
>>         pci_set_master(pdev);
>> -    if (!ionic->is_mgmt_nic)
>> -        pcie_print_link_status(pdev);
>
> Was removing the call intentional? Notice the condition is negated.
>
> Michal
>
Yep, good catch.  Since Dave has already pulled this in, I'll follow up 
with something to put that pcie_print back.

Thanks,
sln