lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 16 Jun 2020 12:56:01 +0800
From:   kernel test robot <lkp@...el.com>
To:     yunaixin03610@....com, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, yunaixin <yunaixin@...wei.com>
Subject: Re: [PATCH 1/5] Huawei BMA: Adding Huawei BMA driver: host_edma_drv

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.8-rc1 next-20200615]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/yunaixin03610-163-com/Adding-Huawei-BMA-drivers/20200616-102318
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a5dc8300df75e8b8384b4c82225f1e4a0b4d9b55
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>, old ones prefixed by <<):

In file included from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.h:21,
from drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:21:
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.h:246:2: error: unknown type name '__kernel_time_t'
246 |  __kernel_time_t init_time;
|  ^~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:67:5: warning: no previous prototype for 'edma_param_get_statics' [-Wmissing-prototypes]
67 | int edma_param_get_statics(char *buf, const struct kernel_param *kp)
|     ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:142:5: warning: no previous prototype for '__atu_config_H' [-Wmissing-prototypes]
142 | s32 __atu_config_H(struct pci_dev *pdev, unsigned int region,
|     ^~~~~~~~~~~~~~
In file included from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.h:20,
from drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:21:
drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c: In function 'ioremap_pme_bar1_mem':
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.h:80:17: error: implicit declaration of function 'ioremap_nocache'; did you mean 'ioremap_cache'? [-Werror=implicit-function-declaration]
80 | #define IOREMAP ioremap_nocache
|                 ^~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:246:7: note: in expansion of macro 'IOREMAP'
246 |       IOREMAP(bma_pci_dev->bma_base_phy_addr,
|       ^~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:245:30: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
245 |   bma_pci_dev->bma_base_addr =
|                              ^
drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c: In function 'ioremap_bar_mem':
drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:310:31: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
310 |   bma_pci_dev->kbox_base_addr =
|                               ^
drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c: At top level:
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:328:5: warning: no previous prototype for 'pme_pci_enable_msi' [-Wmissing-prototypes]
328 | int pme_pci_enable_msi(struct pci_dev *pdev)
|     ^~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:354:5: warning: no previous prototype for 'pci_device_init' [-Wmissing-prototypes]
354 | int pci_device_init(struct pci_dev *pdev, struct bma_pci_dev_s *bma_pci_dev)
|     ^~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:383:5: warning: no previous prototype for 'pci_device_config' [-Wmissing-prototypes]
383 | int pci_device_config(struct pci_dev *pdev)
|     ^~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:505:12: warning: no previous prototype for 'bma_pci_init' [-Wmissing-prototypes]
505 | int __init bma_pci_init(void)
|            ^~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:518:13: warning: no previous prototype for 'bma_pci_cleanup' [-Wmissing-prototypes]
518 | void __exit bma_pci_cleanup(void)
|             ^~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.h:21,
from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.c:26:
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.h:246:2: error: unknown type name '__kernel_time_t'
246 |  __kernel_time_t init_time;
|  ^~~~~~~~~~~~~~~
In file included from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.h:20,
from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.c:26:
drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.c: In function 'bma_cdev_add_msg':
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.h:88:20: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
88 |    netdev_alert(0, "edma: %s, %d, " fmt,          |                    ^~~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.c:500:3: note: in expansion of macro 'BMA_LOG'
500 |   BMA_LOG(DLOG_DEBUG, "msg_len is %ldn", msg_len);
|   ^~~~~~~
drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.c:500:37: note: format string is defined here
500 |   BMA_LOG(DLOG_DEBUG, "msg_len is %ldn", msg_len);
|                                   ~~^
|                                     |
|                                     long int
|                                   %d
--
In file included from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.h:21,
from drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.h:19,
from drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:22:
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.h:246:2: error: unknown type name '__kernel_time_t'
246 |  __kernel_time_t init_time;
|  ^~~~~~~~~~~~~~~
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c: In function 'edmainfo_show':
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:35:2: error: unknown type name '__kernel_time_t'; did you mean '__kernel_timer_t'?
35 |  __kernel_time_t running_time = 0;
|  ^~~~~~~~~~~~~~~
|  __kernel_timer_t
In file included from drivers/net/ethernet/huawei/bma/edma_drv/edma_host.h:19,
from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.h:21,
from drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.h:19,
from drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:22:
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_include.h:109:19: error: storage size of 'uptime' isn't known
109 |   struct timespec uptime;         |                   ^~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:49:2: note: in expansion of macro 'GET_SYS_SECONDS'
49 |  GET_SYS_SECONDS(running_time);
|  ^~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_include.h:110:3: error: implicit declaration of function 'get_monotonic_boottime' [-Werror=implicit-function-declaration]
110 |   get_monotonic_boottime(&uptime);         |   ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:49:2: note: in expansion of macro 'GET_SYS_SECONDS'
49 |  GET_SYS_SECONDS(running_time);
|  ^~~~~~~~~~~~~~~
drivers/net/ethernet/huawei/bma/edma_drv/bma_include.h:109:19: warning: unused variable 'uptime' [-Wunused-variable]
109 |   struct timespec uptime;         |                   ^~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:49:2: note: in expansion of macro 'GET_SYS_SECONDS'
49 |  GET_SYS_SECONDS(running_time);
|  ^~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:55:45: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'int' [-Wformat=]
55 |  len += sprintf(buf + len, "running_time :%luD %02lu:%02lu:%02lun",
|                                           ~~^
|                                             |
|                                             long unsigned int
|                                           %u
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:55:52: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'int' [-Wformat=]
55 |  len += sprintf(buf + len, "running_time :%luD %02lu:%02lu:%02lun",
|                                                ~~~~^
|                                                    |
|                                                    long unsigned int
|                                                %02u
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:55:58: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'int' [-Wformat=]
55 |  len += sprintf(buf + len, "running_time :%luD %02lu:%02lu:%02lun",
|                                                      ~~~~^
|                                                          |
|                                                          long unsigned int
|                                                      %02u
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:55:64: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'int' [-Wformat=]
55 |  len += sprintf(buf + len, "running_time :%luD %02lu:%02lu:%02lun",
|                                                            ~~~~^
|                                                                |
|                                                                long unsigned int
|                                                            %02u
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c: At top level:
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:581:6: warning: no previous prototype for 'host_dma_transfer_without_list' [-Wmissing-prototypes]
581 | void host_dma_transfer_without_list(struct edma_host_s *edma_host,
|      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:608:6: warning: no previous prototype for 'host_dma_transfer_withlist' [-Wmissing-prototypes]
608 | void host_dma_transfer_withlist(struct edma_host_s *edma_host,
|      ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:22:
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c: In function 'edma_host_send_msg':
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.h:88:20: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'unsigned int' [-Wformat=]
88 |    netdev_alert(0, "edma: %s, %d, " fmt,          |                    ^~~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:791:3: note: in expansion of macro 'BMA_LOG'
791 |   BMA_LOG(DLOG_ERROR,
|   ^~~~~~~
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:792:48: note: format string is defined here
792 |    "Length of send message %u is larger than %lun",
|                                              ~~^
|                                                |
|                                                long unsigned int
|                                              %u
In file included from drivers/net/ethernet/huawei/bma/edma_drv/edma_host.h:19,
from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.h:21,
from drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.h:19,
from drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:22:
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c: In function 'edma_host_init':
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_include.h:109:19: error: storage size of 'uptime' isn't known
109 |   struct timespec uptime;         |                   ^~~~~~
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:1410:2: note: in expansion of macro 'GET_SYS_SECONDS'
1410 |  GET_SYS_SECONDS(edma_host->statistics.init_time);
|  ^~~~~~~~~~~~~~~
drivers/net/ethernet/huawei/bma/edma_drv/bma_include.h:109:19: warning: unused variable 'uptime' [-Wunused-variable]
109 |   struct timespec uptime;         |                   ^~~~~~
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:1410:2: note: in expansion of macro 'GET_SYS_SECONDS'
1410 |  GET_SYS_SECONDS(edma_host->statistics.init_time);
|  ^~~~~~~~~~~~~~~
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c: In function 'edma_host_cleanup':
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:1434:20: warning: variable 'bma_dev' set but not used [-Wunused-but-set-variable]
1434 |  struct bma_dev_s *bma_dev = NULL;
|                    ^~~~~~~
cc1: some warnings being treated as errors

vim +/__kernel_time_t +246 drivers/net/ethernet/huawei/bma/edma_drv/edma_host.h

   243	
   244	struct edma_statistics_s {
   245		unsigned int remote_status;
 > 246		__kernel_time_t init_time;
   247		unsigned int h2b_int;
   248		unsigned int b2h_int;
   249		unsigned int recv_bytes;
   250		unsigned int send_bytes;
   251		unsigned int send_pkgs;
   252		unsigned int recv_pkgs;
   253		unsigned int failed_count;
   254		unsigned int drop_pkgs;
   255		unsigned int dma_count;
   256		unsigned int lost_count;
   257	};
   258	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (73467 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ