| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202006161347.x11KAvP5%lkp@intel.com>
Date: Tue, 16 Jun 2020 13:54:49 +0800
From: kernel test robot <lkp@...el.com>
To: yunaixin03610@....com, netdev@...r.kernel.org
Cc: kbuild-all@...ts.01.org, yunaixin <yunaixin@...wei.com>
Subject: Re: [PATCH 2/5] Huawei BMA: Adding Huawei BMA driver: host_cdev_drv
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.8-rc1 next-20200616]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/yunaixin03610-163-com/Adding-Huawei-BMA-drivers/20200616-102318
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a5dc8300df75e8b8384b4c82225f1e4a0b4d9b55
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All error/warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/net/ethernet/huawei/bma/cdev_drv/bma_cdev.c: In function 'cdev_param_get_statics':
>> drivers/net/ethernet/huawei/bma/cdev_drv/bma_cdev.c:97:2: error: unknown type name '__kernel_time_t'; did you mean '__kernel_timer_t'?
97 | __kernel_time_t running_time = 0;
| ^~~~~~~~~~~~~~~
| __kernel_timer_t
In file included from drivers/net/ethernet/huawei/bma/cdev_drv/bma_cdev.c:23:
>> drivers/net/ethernet/huawei/bma/cdev_drv/../edma_drv/bma_include.h:109:19: error: storage size of 'uptime' isn't known
109 | struct timespec uptime; | ^~~~~~
>> drivers/net/ethernet/huawei/bma/cdev_drv/bma_cdev.c:102:2: note: in expansion of macro 'GET_SYS_SECONDS'
102 | GET_SYS_SECONDS(running_time);
| ^~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/cdev_drv/../edma_drv/bma_include.h:110:3: error: implicit declaration of function 'get_monotonic_boottime' [-Werror=implicit-function-declaration]
110 | get_monotonic_boottime(&uptime); | ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/cdev_drv/bma_cdev.c:102:2: note: in expansion of macro 'GET_SYS_SECONDS'
102 | GET_SYS_SECONDS(running_time);
| ^~~~~~~~~~~~~~~
drivers/net/ethernet/huawei/bma/cdev_drv/../edma_drv/bma_include.h:109:19: warning: unused variable 'uptime' [-Wunused-variable]
109 | struct timespec uptime; | ^~~~~~
>> drivers/net/ethernet/huawei/bma/cdev_drv/bma_cdev.c:102:2: note: in expansion of macro 'GET_SYS_SECONDS'
102 | GET_SYS_SECONDS(running_time);
| ^~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/cdev_drv/bma_cdev.c:108:45: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'int' [-Wformat=]
108 | len += sprintf(buf + len, "running_time :%luD %02lu:%02lu:%02lun",
| ~~^
| |
| long unsigned int
| %u
109 | running_time / (SECONDS_PER_DAY),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| int
drivers/net/ethernet/huawei/bma/cdev_drv/bma_cdev.c:108:52: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'int' [-Wformat=]
108 | len += sprintf(buf + len, "running_time :%luD %02lu:%02lu:%02lun",
| ~~~~^
| |
| long unsigned int
| %02u
drivers/net/ethernet/huawei/bma/cdev_drv/bma_cdev.c:108:58: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'int' [-Wformat=]
108 | len += sprintf(buf + len, "running_time :%luD %02lu:%02lu:%02lun",
| ~~~~^
| |
| long unsigned int
| %02u
drivers/net/ethernet/huawei/bma/cdev_drv/bma_cdev.c:108:64: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'int' [-Wformat=]
108 | len += sprintf(buf + len, "running_time :%luD %02lu:%02lu:%02lun",
| ~~~~^
| |
| long unsigned int
| %02u
In file included from drivers/net/ethernet/huawei/bma/cdev_drv/bma_cdev.c:23:
drivers/net/ethernet/huawei/bma/cdev_drv/bma_cdev.c: In function 'bma_cdev_init':
>> drivers/net/ethernet/huawei/bma/cdev_drv/../edma_drv/bma_include.h:109:19: error: storage size of 'uptime' isn't known
109 | struct timespec uptime; | ^~~~~~
drivers/net/ethernet/huawei/bma/cdev_drv/bma_cdev.c:216:2: note: in expansion of macro 'GET_SYS_SECONDS'
216 | GET_SYS_SECONDS(g_cdev_set.init_time);
| ^~~~~~~~~~~~~~~
drivers/net/ethernet/huawei/bma/cdev_drv/../edma_drv/bma_include.h:109:19: warning: unused variable 'uptime' [-Wunused-variable]
109 | struct timespec uptime; | ^~~~~~
drivers/net/ethernet/huawei/bma/cdev_drv/bma_cdev.c:216:2: note: in expansion of macro 'GET_SYS_SECONDS'
216 | GET_SYS_SECONDS(g_cdev_set.init_time);
| ^~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +97 drivers/net/ethernet/huawei/bma/cdev_drv/bma_cdev.c
92
93 static int cdev_param_get_statics(char *buf, const struct kernel_param *kp)
94 {
95 int len = 0;
96 int i = 0;
> 97 __kernel_time_t running_time = 0;
98
99 if (!buf)
100 return 0;
101
> 102 GET_SYS_SECONDS(running_time);
103 running_time -= g_cdev_set.init_time;
104 len += sprintf(buf + len,
105 "============================CDEV_DRIVER_INFO=======================\n");
106 len += sprintf(buf + len, "version :%s\n", CDEV_VERSION);
107
> 108 len += sprintf(buf + len, "running_time :%luD %02lu:%02lu:%02lu\n",
109 running_time / (SECONDS_PER_DAY),
110 running_time % (SECONDS_PER_DAY) / SECONDS_PER_HOUR,
111 running_time % SECONDS_PER_HOUR / SECONDS_PER_MINUTE,
112 running_time % SECONDS_PER_MINUTE);
113
114 for (i = 0; i < g_cdev_set.dev_num; i++) {
115 len += sprintf(buf + len,
116 "===================================================\n");
117 len += sprintf(buf + len, "name :%s\n",
118 g_cdev_set.dev_list[i].dev_name);
119 len +=
120 sprintf(buf + len, "dev_id :%08x\n",
121 g_cdev_set.dev_list[i].dev_id);
122 len += sprintf(buf + len, "type :%u\n",
123 g_cdev_set.dev_list[i].type);
124 len += sprintf(buf + len, "status :%s\n",
125 g_cdev_set.dev_list[i].s.open_status ==
126 1 ? "open" : "close");
127 len += sprintf(buf + len, "send_pkgs :%u\n",
128 g_cdev_set.dev_list[i].s.send_pkgs);
129 len +=
130 sprintf(buf + len, "send_bytes:%u\n",
131 g_cdev_set.dev_list[i].s.send_bytes);
132 len += sprintf(buf + len, "send_failed_count:%u\n",
133 g_cdev_set.dev_list[i].s.send_failed_count);
134 len += sprintf(buf + len, "recv_pkgs :%u\n",
135 g_cdev_set.dev_list[i].s.recv_pkgs);
136 len += sprintf(buf + len, "recv_bytes:%u\n",
137 g_cdev_set.dev_list[i].s.recv_bytes);
138 len += sprintf(buf + len, "recv_failed_count:%u\n",
139 g_cdev_set.dev_list[i].s.recv_failed_count);
140 }
141
142 return len;
143 }
144 module_param_call(statistics, NULL, cdev_param_get_statics, &debug, 0444);
145 MODULE_PARM_DESC(statistics, "Statistics info of cdev driver,readonly");
146
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (73467 bytes)
Powered by blists - more mailing lists