netdev - Re: [PATCH ipsec-next 02/10] tunnel4: add cb_handler to struct xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200617091905.2b007939@kicinski-fedora-PC1C0HJN>
Date:   Wed, 17 Jun 2020 09:19:05 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Xin Long <lucien.xin@...il.com>
Cc:     netdev@...r.kernel.org,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: [PATCH ipsec-next 02/10] tunnel4: add cb_handler to struct
 xfrm_tunnel

On Wed, 17 Jun 2020 01:36:27 +0800 Xin Long wrote:
> This patch is to register a callback function tunnel4_rcv_cb with
> is_ipip set in a xfrm_input_afinfo object for tunnel4 and tunnel64.
> 
> It will be called by xfrm_rcv_cb() from xfrm_input() when family
> is AF_INET and proto is IPPROTO_IPIP or IPPROTO_IPV6.
> 
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Please make sure W=1 C=1 builds don't add new warnings:

net/ipv4/tunnel4.c:118:14: warning: incorrect type in assignment (different address spaces)
net/ipv4/tunnel4.c:118:14:    expected struct xfrm_tunnel *head
net/ipv4/tunnel4.c:118:14:    got struct xfrm_tunnel [noderef] <asn:4> *
net/ipv4/tunnel4.c:120:9: error: incompatible types in comparison expression (different address spaces):
net/ipv4/tunnel4.c:120:9:    struct xfrm_tunnel [noderef] <asn:4> *
net/ipv4/tunnel4.c:120:9:    struct xfrm_tunnel *