netdev - Re: [PATCH net v2] net: core: reduce recursion limit value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 Jun 2020 20:13:59 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ap420073@...il.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org, fw@...len.de
Subject: Re: [PATCH net v2] net: core: reduce recursion limit value

From: Taehee Yoo <ap420073@...il.com>
Date: Tue, 16 Jun 2020 15:52:05 +0000

> In the current code, ->ndo_start_xmit() can be executed recursively only
> 10 times because of stack memory.
> But, in the case of the vxlan, 10 recursion limit value results in
> a stack overflow.
> In the current code, the nested interface is limited by 8 depth.
> There is no critical reason that the recursion limitation value should
> be 10.
> So, it would be good to be the same value with the limitation value of
> nesting interface depth.
> 
> Test commands:
 ...
> Splat looks like:
 ...
> 
> Fixes: 11a766ce915f ("net: Increase xmit RECURSION_LIMIT to 10.")
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

Applied and queued up for -stable, thanks.