netdev - Re: [net-next PATCH] net: Avoid overwriting valid skb->napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 20 Jun 2020 17:31:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     amritha.nambiar@...el.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com,
        alexander.h.duyck@...el.com, eliezer.tamir@...ux.intel.com,
        sridhar.samudrala@...el.com
Subject: Re: [net-next PATCH] net: Avoid overwriting valid skb->napi_id

From: Amritha Nambiar <amritha.nambiar@...el.com>
Date: Thu, 18 Jun 2020 14:22:15 -0700

> This will be useful to allow busy poll for tunneled traffic. In case of
> busy poll for sessions over tunnels, the underlying physical device's
> queues need to be polled.
> 
> Tunnels schedule NAPI either via netif_rx() for backlog queue or
> schedule the gro_cell_poll(). netif_rx() propagates the valid skb->napi_id
> to the socket. OTOH, gro_cell_poll() stamps the skb->napi_id again by
> calling skb_mark_napi_id() with the tunnel NAPI which is not a busy poll
> candidate. This was preventing tunneled traffic to use busy poll. A valid
> NAPI ID in the skb indicates it was already marked for busy poll by a
> NAPI driver and hence needs to be copied into the socket.
> 
> Signed-off-by: Amritha Nambiar <amritha.nambiar@...el.com>

Applied, thank you.