netdev - Re: [PATCH net] r8169: fix firmware not resetting tp->ocp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200620.173211.41576810184648578.davem@davemloft.net>
Date:   Sat, 20 Jun 2020 17:32:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, kuba@...nel.org, mapengyu@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] r8169: fix firmware not resetting tp->ocp_base

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Thu, 18 Jun 2020 23:25:50 +0200

> Typically the firmware takes care that tp->ocp_base is reset to its
> default value. That's not the case (at least) for RTL8117.
> As a result subsequent PHY access reads/writes the wrong page and
> the link is broken. Fix this be resetting tp->ocp_base explicitly.
> 
> Fixes: 229c1e0dfd3d ("r8169: load firmware for RTL8168fp/RTL8117")
> Reported-by: Aaron Ma <mapengyu@...il.com>
> Tested-by: Aaron Ma <mapengyu@...il.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied and queued up for v5.5 -stable, thanks.