netdev - Re: [PATCH ipsec-next 03/10] tunnel6: add tunnel6_input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADvbK_fP2ezY3e-+DGBqxhKaMQn3E-kNgAGDZc5qaGPKx_yjjQ@mail.gmail.com>
Date:   Mon, 22 Jun 2020 16:30:07 +0800
From:   Xin Long <lucien.xin@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     network dev <netdev@...r.kernel.org>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: [PATCH ipsec-next 03/10] tunnel6: add tunnel6_input_afinfo for
 ipip and ipv6 tunnels

On Thu, Jun 18, 2020 at 12:19 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 17 Jun 2020 01:36:28 +0800 Xin Long wrote:
> > This patch is to register a callback function tunnel6_rcv_cb with
> > is_ipip set in a xfrm_input_afinfo object for tunnel6 and tunnel46.
> >
> > It will be called by xfrm_rcv_cb() from xfrm_input() when family
> > is AF_INET6 and proto is IPPROTO_IPIP or IPPROTO_IPV6.
> >
> > Signed-off-by: Xin Long <lucien.xin@...il.com>
>
> net/ipv6/tunnel6.c:163:14: warning: incorrect type in assignment (different address spaces)
> net/ipv6/tunnel6.c:163:14:    expected struct xfrm6_tunnel *head
> net/ipv6/tunnel6.c:163:14:    got struct xfrm6_tunnel [noderef] <asn:4> *
> net/ipv6/tunnel6.c:165:9: error: incompatible types in comparison expression (different address spaces):
> net/ipv6/tunnel6.c:165:9:    struct xfrm6_tunnel [noderef] <asn:4> *
> net/ipv6/tunnel6.c:165:9:    struct xfrm6_tunnel *
will change to:

 static int tunnel6_rcv_cb(struct sk_buff *skb, u8 proto, int err)
 {
-       struct xfrm6_tunnel *head, *handler;
+       struct xfrm6_tunnel __rcu *head;
+       struct xfrm6_tunnel *handler;
        int ret;